Ticket #567 (closed defect: fixed)

Opened 2 years ago

Last modified 17 months ago

Trendsetter Problems

Reported by: mchandler Owned by: mankoff
Priority: blocker Milestone: Spring 2007
Component: EdGCM Version: EdGCM 3.0
Keywords: Cc:
OS:

Description (last modified by mankoff) (diff)

Need to fix an error in Trendsetter that yields bogus values when using negative numbers that contain decimals.

Change History

Changed 22 months ago by mchandler

This should be fixed before the 3.0.1 release....

Changed 22 months ago by mchandler

...it must just be a fortran coding or format error

Changed 22 months ago by mankoff

  • owner changed from mshopsin to mankoff

Changed 18 months ago by mankoff

  • status changed from new to assigned

Changed 18 months ago by mankoff

  • cc mchandler removed
  • description modified (diff)

Changed 18 months ago by mankoff

The bug is not in TrendSetter FORTRAN but in EdGCM. The "trendSetter.I" file created when you press "view" already demonstrates the bug. This file is the input to the FORTRAN code.

Changed 18 months ago by mankoff

The fix was to change the home-brewed formatting algorithm 

  `convert real to string
  $temp:=String(Int($float))
  $str:=(Char(Space )*(7-Length($temp)))+$temp
  $temp:=String(Int(Dec($float)*100000000))
  $str:=$str+"."+("0"*(8-Length($temp)))+$temp

To use the 4D format function: 

$str:=String($float;"######0.00000000")

This bug occured in the RealToF18.5 method.

Changed 18 months ago by mankoff

  • status changed from assigned to closed
  • resolution set to fixed

Checked in fix in [667]

Changed 17 months ago by mankoff

  • milestone changed from EdGCM 3.1 to Spring 2007
Note: See TracTickets for help on using tickets.